From fee5fb3c955dd8068bdfbbd14a2a4fe2bf288451 Mon Sep 17 00:00:00 2001
From: Michael Bradley <michaelmbrad@gmail.com>
Date: Sat, 25 Oct 2025 21:50:02 -0400
Subject: [PATCH] Replace specific networking trait bounds with general
 Networked trait

---
 src/net/distribution.rs | 50 +++++++++++++++++++++++++++++++++--------
 src/net/mod.rs          |  4 +++-
 2 files changed, 44 insertions(+), 10 deletions(-)

diff --git a/src/net/distribution.rs b/src/net/distribution.rs
index 70f2061..9d97287 100644
--- a/src/net/distribution.rs
+++ b/src/net/distribution.rs
@@ -8,44 +8,76 @@ use super::{
 #[derive(Component)]
 pub struct PeerOwned;
 
-fn spawner<T: TryFrom<Vec<u8>> + Component>(
+pub trait Networked: Component + NetworkEncodable + NetworkDecodable {}
+
+impl<T> Networked for T where T: Component + NetworkEncodable + NetworkDecodable {}
+
+pub trait NetworkEncodable {
+    fn encode(&self) -> Vec<u8>;
+}
+
+impl<T> NetworkEncodable for T
+where
+    T: Clone + Into<Vec<u8>>,
+{
+    fn encode(&self) -> Vec<u8> {
+        self.clone().into()
+    }
+}
+
+pub trait NetworkDecodable: Sized {
+    type DecodeError;
+    fn decode(buffer: Vec<u8>) -> std::result::Result<Self, Self::DecodeError>;
+}
+
+impl<T> NetworkDecodable for T
+where
+    T: TryFrom<Vec<u8>>,
+{
+    type DecodeError = T::Error;
+    fn decode(buffer: Vec<u8>) -> std::result::Result<Self, Self::DecodeError> {
+        T::try_from(buffer)
+    }
+}
+
+fn spawner<T: NetworkDecodable + Component>(
     mut inbound: MessageReader<InboundPacket>,
     mut commands: Commands,
 ) {
     for InboundPacket(packet) in inbound.read() {
-        if let Ok(component) = T::try_from(packet.message.clone()) {
+        if let Ok(component) = T::decode(packet.message.clone()) {
             commands.spawn((component, PeerOwned));
         }
     }
 }
 
-fn new_peer<T: Into<Vec<u8>> + Component + Clone>(
+fn new_peer<T: NetworkEncodable + Component>(
     add: On<Add, PeerID>,
-    peers: Query<&PeerID>,
     components: Query<&T, Without<PeerOwned>>,
+    peers: Query<&PeerID>,
     mut outbound: MessageWriter<OutboundPacket>,
 ) -> Result {
     let peer = peers.get(add.entity)?;
     for component in components {
-        outbound.write(Packet::create(component.clone().into(), peer.id));
+        outbound.write(Packet::create(component.encode(), peer.id));
     }
     Ok(())
 }
 
-fn new_entity<T: Into<Vec<u8>> + Component + Clone>(
+fn new_entity<T: NetworkEncodable + Component>(
     add: On<Add, T>,
-    peers: Query<&PeerID>,
     components: Query<&T, Without<PeerOwned>>,
+    peers: Query<&PeerID>,
     mut outbound: MessageWriter<OutboundPacket>,
 ) {
     if let Ok(component) = components.get(add.entity) {
         for peer in peers {
-            outbound.write(Packet::create(component.clone().into(), peer.id));
+            outbound.write(Packet::create(component.encode(), peer.id));
         }
     }
 }
 
-pub fn distribution_plugin<T: Into<Vec<u8>> + TryFrom<Vec<u8>> + Component + Clone>(app: &mut App) {
+pub fn distribution_plugin<T: Networked>(app: &mut App) {
     app.add_systems(FixedUpdate, spawner::<T>)
         .add_observer(new_peer::<T>)
         .add_observer(new_entity::<T>);
diff --git a/src/net/mod.rs b/src/net/mod.rs
index 69f2151..1a5834c 100644
--- a/src/net/mod.rs
+++ b/src/net/mod.rs
@@ -10,7 +10,9 @@ mod thread;
 
 #[allow(unused_imports)]
 pub mod prelude {
-    pub use super::distribution::distribution_plugin;
+    pub use super::distribution::{
+        NetworkDecodable, NetworkEncodable, Networked, distribution_plugin,
+    };
     pub use super::packet::{InboundPacket, OutboundPacket, Packet};
     pub use super::peer::{Peer, PeerID, PeerReceiveTiming, PeerSendTiming, PotentialPeers};
     pub use super::plugin::NetIOPlugin;